test: use ERM to destroy sqlite database handles after tests#63076
Open
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Open
test: use ERM to destroy sqlite database handles after tests#63076Renegade334 wants to merge 1 commit intonodejs:mainfrom
Renegade334 wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #63076 +/- ##
==========================================
- Coverage 89.65% 89.63% -0.02%
==========================================
Files 712 712
Lines 220498 220498
Branches 42278 42276 -2
==========================================
- Hits 197683 197651 -32
- Misses 14663 14705 +42
+ Partials 8152 8142 -10 🚀 New features to boost your workflow:
|
atlowChemi
approved these changes
May 3, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
louwers
reviewed
May 3, 2026
| }); | ||
| }); | ||
|
|
||
| suite('DatabaseSync.prototype[Symbol.dispose]', () => { |
Contributor
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
👍
Should be a straightforward conflict to resolve in either direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the tests in test-sqlite-database-sync were using test runner "after" hooks to close down database handles on test completion, but not all. This appears to have caused a timing issue on some of the Windows runners where the
process.on('exit')handler can be attempting to clean up the tempdir while sqlite3 still has active locks on the database files.We could just add those same hooks to all the remaining tests, but we may as well use the language feature designed for this purpose!
Drive-by: we had two DatabaseSync tests in a separate file with duplicated test machinery, so folded these into the main test file.
Refs: #63052